Mustache specs - whitespace compliance #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a standalone template should be indented before it is applied on view data rather than after as in the previous commit. To accomplish this I added a cache for keeping the partial templates, not just the complied result and added an 'indentation' argument to getPartial and compilePartial.
|
@danielfagerstrom Would you please rework this pull request to include only the commits that have to do with whitespace compliance? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the failing whitespace tests from the Mustache spec from my Mustache spec pull request.
is used standalone, any whitespace preceding the tag should treated as
indentation, and prepended to each line of the partial before rendering. specs
To implement the second point I introduced a
whitespacevariable in theparsefunction to keep track on whitespace on the same row before a standalone tag. For partials the content of thewhitespacevariables is stored in the parse tree and used for compiling an indented version of the partial during rendering. To keep track on instances of the same partial with different of indentation in the partial cache I prefixed the partial name with the indentation in the cache. Also needed to store non compiled partials and introduced indentation arguments forgetPartialandcompilePartial.The implementation borrowed from Milk.